Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arm64 image #218

Merged
merged 3 commits into from
Apr 1, 2025
Merged

feat: add arm64 image #218

merged 3 commits into from
Apr 1, 2025

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Oct 17, 2024

I am trying to run the same image locally, to see errors directly locally. BUT it has only amd64 so it's slow as hell on mac.

Before: 7m20s
Now: 23s

After merge a new docker image will appear:

ghcr.io/rojopolis/spellcheck-github-actions:master on GitHub. Open the package on the right side and change visiblity to public

After that change in action.yml it to: ghcr.io/rojopolis/spellcheck-github-actions:0.44.0 and tag only a 0.44.0 and wait for pipeline finish. When pipeline finished, create a release for GitHub Action Marketplace

@mitelg
Copy link

mitelg commented Oct 17, 2024

duplicate of #108 ?

@jonasbn jonasbn self-requested a review October 27, 2024 13:30
jonasbn
jonasbn requested changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shyim

This looks great. I have added some comments and requests for changes. And I have some questions in regard to the tag part.

Thank you

@jonasbn jonasbn mentioned this pull request Mar 29, 2025
Closed
@jonasbn
Copy link
Collaborator

jonasbn commented Mar 29, 2025

closes #193

@jonasbn jonasbn linked an issue Mar 29, 2025 that may be closed by this pull request
Provide arm64 docker image #193
Closed
@jonasbn
Copy link
Collaborator

jonasbn commented Mar 29, 2025

@mitelg it seems to be related to #108 and there are overlaps. When this PR is merged, I will evaluate how we get the build and release processed to be completely automatic and we can close #108 also.

@shyim shyim requested a review from jonasbn April 1, 2025 07:32
jonasbn
jonasbn approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shyim

This is approved

@jonasbn jonasbn merged commit 8e8540e into rojopolis:master Apr 1, 2025
@shyim shyim deleted the add-arm64 branch April 1, 2025 13:48
@jonasbn jonasbn added the docker Pull requests that update Docker code label Apr 1, 2025
@jonasbn jonasbn mentioned this pull request Apr 1, 2025
Closed
jonasbn pushed a commit to funkill/spellcheck-github-actions that referenced this pull request Apr 1, 2025
@shyim @jonasbn
feat: add arm64 image (rojopolis#218)
8fa2218 
* feat: add arm64 image

* ci: pin actions

* ci: add sha
jonasbn added a commit that referenced this pull request Apr 1, 2025
@funkill @dependabot
@jonasbn @brooke-hamilton @shyim
Hunspell support, dictionaries, update links (#224)
5a7e4ea 
* added hunspel with en, de, es and fr dictionaries, update docs

* added russian and ukranian dicts, update docs

* updated os version in packages links

* fixed spelling

* fixed entrypoint

* Bump python from 3.13.0-slim-bookworm to 3.13.1-slim-bookworm

Bumps python from 3.13.0-slim-bookworm to 3.13.1-slim-bookworm.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Preparing release 0.46.0, update to Docker base image

* Bump nosborn/github-action-markdown-cli from 3.3.0 to 3.4.0

Bumps [nosborn/github-action-markdown-cli](https://github.com/nosborn/github-action-markdown-cli) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/nosborn/github-action-markdown-cli/releases)
- [Commits](nosborn/github-action-markdown-cli@v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: nosborn/github-action-markdown-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump python from 3.13.1-slim-bookworm to 3.13.2-slim-bookworm

Bumps python from 3.13.1-slim-bookworm to 3.13.2-slim-bookworm.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Preparing release 0.47.0

* add tool versions (#234)

Signed-off-by: Brooke Hamilton <[email protected]>

* feat: add arm64 image (#218)

* feat: add arm64 image

* ci: pin actions

* ci: add sha

* ci: fix default branch name (#235)

* Added hunspell version output to entry point

* Did some testing, added more output to entrypoint, parameter specification in action.yml and some documentation

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Brooke Hamilton <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jonasbn <[email protected]>
Co-authored-by: Brooke Hamilton <[email protected]>
Co-authored-by: Shyim <[email protected]>
Co-authored-by: Jonas Brømsø <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees
No one assigned
Labels
docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide arm64 docker image
3 participants
@shyim @mitelg @jonasbn