Skip to content

feat(proto): introduce iceberg compaction proto #21778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2025
Merged

feat(proto): introduce iceberg compaction proto #21778

merged 6 commits into from
May 8, 2025
+146 −6

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented May 8, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

part of #21669

  1. introduce dedicated iceberg compaction proto
  2. reuse hummock service and client

The implementation of RPC will be completed in the next PR.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k requested review from chenzl25 and xxhZs May 8, 2025 07:46
@Li0k Li0k enabled auto-merge May 8, 2025 07:59
chenzl25
chenzl25 approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k Li0k added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 1611e1b May 8, 2025
34 of 35 checks passed
@Li0k Li0k deleted the li0k/iceberg_compact_proto branch May 8, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzl25 chenzl25 chenzl25 approved these changes

@xxhZs xxhZs xxhZs approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-iceberg-tests ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Li0k @chenzl25 @xxhZs