refactor(compaction): refactor compaction event stream #21669
Merged
+793
−341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/refactor_compact_event_stream
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the compaction event stream by introducing support for a new iceberg compaction event stream alongside the existing implementation. Key changes include:
- Adding new feature flags and types to support iceberg compaction events.
- Updating HummockManager and related modules (compaction manager, compactor manager, service, and proto definitions) to handle separate event loops and API endpoints for iceberg compaction.
- Adjusting test utilities and worker modules to accommodate the new iceberg compactor stream.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/meta/src/lib.rs | Added a new feature flag (adt_const_params) required by updated code. |
| src/meta/src/hummock/test_utils.rs | Introduced a new channel for iceberg compactor streams. |
| src/meta/src/hummock/mock_hummock_meta_client.rs | Updated usage of compactor manager API to reflect renaming. |
| src/meta/src/hummock/manager/worker.rs | Added a TODO comment for eventual removal of the iceberg compactor. |
| src/meta/src/hummock/manager/mod.rs | Extended HummockManager with iceberg compactor manager and updated initialization routines. |
| src/meta/src/hummock/manager/compaction/mod.rs | Refactored event loop implementation to include dedicated handlers for both compaction types. |
| src/meta/src/hummock/compactor_manager.rs | Added new iceberg compactor types and traits, along with respective tests. |
| src/meta/service/src/hummock_service.rs | Added a new subscribe API method for iceberg compaction events. |
| src/meta/node/src/server.rs | Integrated the new iceberg compactor stream into service startup. |
| proto/hummock.proto | Added new proto messages for iceberg compaction events. |
Comments suppressed due to low confidence (1)
proto/hummock.proto:845
- [nitpick] Ensure that the field numbering (using 7 for create_at) is intentional and document the rationale, especially if gaps in numbering are reserved for future extensions.
uint64 create_at = 7;
| tokio::select! { | ||
| _ = shutdown_rx_shared => { return; }, | ||
| // TODO(li0k): move this to iceberg compaction manager | ||
| // when iceberg compaction manager is ready. |
There was a problem hiding this comment.
[nitpick] Consider adding a reference to a tracking issue or additional context in this TODO comment to clarify the future plan for migrating this logic into the dedicated iceberg compaction manager.
Suggested change
| // when iceberg compaction manager is ready. | |
| // when iceberg compaction manager is ready. See tracking issue #12345 | |
| // for details on the migration plan and readiness criteria. |
Copilot uses AI. Check for mistakes.
|
Failed: 0 PassedExecutions: |
…nto li0k/refactor_compact_event_stream
zwang28
approved these changes
May 7, 2025
This was referenced May 8, 2025
…nto li0k/refactor_compact_event_stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Note that this PR is just the framework, not the full implementation. Subsequent updates will introduce the complete implementation.
Checklist
Documentation
Release note