Skip to content

fix: fix the self-reference issue in the sink into table creation #21103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Mar 25, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #20923

Summary

This pull request introduces key modifications to address circular dependency issues in table and sink creation within the database.

Self-Referencing Check:

  • Enhanced the utility functions in utils.rs to include a check for self-referencing objects. This improvement enables the system to correctly identify and handle cases where a target table may refer to itself, thus mitigating potential circular dependencies.

This set of changes lays the groundwork for robust dependency management in table and sink operations, paving the way for future enhancements.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@shanicky shanicky enabled auto-merge March 25, 2025 10:24
@shanicky shanicky added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit a60dec0 Mar 25, 2025
56 of 57 checks passed
@shanicky shanicky deleted the peng/fix-20923 branch March 25, 2025 12:06
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected failure when sink into table with watermark
3 participants