fix: fix the self-reference issue in the sink into table creation (#21103)

Signed-off-by: Shanicky Chen <[email protected]>

Author: shanicky

e2e_test/sink/sink_into_table/cycle.slt

@@ -1,4 +1,9 @@
 # cycle check
+statement ok
+create table t_t(v int primary key);
+
+statement error Creating such a sink will result in circular dependency
+create sink t_s into t_t from t_t;
 
 statement ok
 create table t_a(v int primary key);
@@ -33,6 +38,9 @@ drop table t_b;
 statement ok
 drop table t_c;
 
+statement ok
+drop table t_t;
+
 # cycle check (with materialize view)
 
 statement ok

src/meta/src/controller/utils.rs

@@ -328,6 +328,11 @@ where
         return Ok(false);
     }
 
+    // special check for self referencing
+    if dependent_objs.contains(&target_table) {
+        return Ok(true);
+    }
+
     let query = construct_sink_cycle_check_query(target_table, dependent_objs);
     let (sql, values) = query.build_any(&*db.get_database_backend().get_query_builder());