Skip to content

fix: patch rquickjs-sys and remove clang dependency #14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix: patch rquickjs-sys and remove clang dependency #14817

merged 1 commit into from
Jan 26, 2024

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR reverts #14761 and uses the upstream rquickjs-sys (unpublished) to fix build on arm64 linux.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

@wangrunji0408 wangrunji0408 requested a review from a team as a code owner January 26, 2024 08:07
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Jan 26, 2024
@huangjw806 huangjw806 mentioned this pull request Jan 26, 2024
Closed
9 tasks
@huangjw806
Copy link
Contributor

test pipeline: https://buildkite.com/risingwavelabs/docker/builds/15070

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 26, 2024
BugenZhao
BugenZhao reviewed Jan 26, 2024
View reviewed changes
ci/Dockerfile
@@ -13,7 +13,7 @@ RUN sed -i 's|http://archive.ubuntu.com/ubuntu|http://us-east-2.ec2.archive.ubun
RUN apt-get update -yy && \
DEBIAN_FRONTEND=noninteractive apt-get -y install make build-essential cmake protobuf-compiler curl parallel python3 python3-pip \
openssl libssl-dev libsasl2-dev libcurl4-openssl-dev pkg-config bash openjdk-11-jdk wget unzip git tmux lld postgresql-client kafkacat netcat mysql-client \
maven zstd libzstd-dev locales clang -yy \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version update is missed, while it's not a big deal.

Merged via the queue into main with commit dad4387 Jan 26, 2024
@wangrunji0408 wangrunji0408 deleted the wrj/fix-rquickjs branch January 26, 2024 09:19
@cyliu0 cyliu0 mentioned this pull request Jan 31, 2024
Closed
@wangrunji0408 wangrunji0408 mentioned this pull request Jan 31, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@huangjw806 huangjw806 huangjw806 approved these changes

Assignees
No one assigned
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangrunji0408 @huangjw806 @BugenZhao