Skip to content

fix: add clang for release script #14812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add clang for release script #14812

wants to merge 1 commit into from

Conversation

huangjw806
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Jan 26, 2024
@huangjw806 huangjw806 requested a review from MrCroxx January 26, 2024 06:35
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested it?

BTW, I'm curious why we use different scripts for building RisingWave for binary releases and Docker releases.

@huangjw806
Copy link
Contributor Author

huangjw806 commented Jan 26, 2024

BTW, I'm curious why we use different scripts for building RisingWave for binary releases and Docker releases.

This is because compiling binary requires using a lower version of glibc, otherwise it will not run in different environments.

#4556

@huangjw806
Copy link
Contributor Author

Have we tested it?

test pipeline: https://buildkite.com/risingwavelabs/docker/builds/15068

@huangjw806
Copy link
Contributor Author

fixed by #14817

@huangjw806 huangjw806 closed this Jan 26, 2024
@BugenZhao
Copy link
Member

This is because compiling binary requires using a lower version of glibc

Can the lower version of glibc be adopted for the docker image as well?

@xxchan xxchan deleted the jianwei/fix-clang branch March 11, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants