refactor(connector): directly deserialize config from map

[BugenZhao]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Avoid first converting a map into a json value, then deserialize it back.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[BugenZhao]

• refactor(connector): directly deserialize config from map #14775 👈
• refactor(error): dedicated error type for dml crate #14768
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on Graphite

[BugenZhao]

Oops. Seems not working as expected. 😕

[xiangjinwu]

e2e_test/source/basic/ddl.slt                                .. [FAILED]
failed to run `e2e_test/source/basic/ddl.slt`
Caused by:
    statement is expected to fail with error:
    	(multiline) db error: ERROR: Failed to run the query
    
    Caused by these errors (recent errors listed first):
      1: gRPC request to meta service failed: Internal error
      2: failed to create source worker
      3: missing field `properties.bootstrap.server`
    but got error:
    	db error: ERROR: Failed to run the query
    
    Caused by these errors (recent errors listed first):
      1: gRPC request to meta service failed: Internal error
      2: failed to create source worker
      3: Serde("missing field `properties.bootstrap.server`") at character 0
    
    [SQL] create source s(x int) WITH(unknown_field='1', connector='kafka') FORMAT PLAIN ENCODE JSON;
    at e2e_test/source/basic/ddl.slt:23

Seems only an appearance issue.

[xiangjinwu]

Do not quite get this part. Is there a unit test to demonstrate what would happen if it was simply (k.as_ref(), v.as_ref())? It is also confusing for caller to get a simd_json::Error.

[xxchan]

Maybe return anyhow::Error here and thus save some conversions outside.

[BugenZhao]

It's kind of counterintuitive, but actually we need something like this:

https://github.com/BugenZhao/rust-playground/blob/7906ca8968d1447871b77932f15ff1f8cfa53f05/src/bin/serde_from_map.rs

[xxchan]

test

[github-actions]

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

[github-actions]

Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏

You can reopen it when you have time to continue working on it.