refactor(error): dedicated error type for dml crate
#14768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Jan 24, 2024
Comment on lines
-51
to
-53
| /// Receive messages from the reader. Hang up on error. | ||
| #[try_stream(ok = M, error = StreamExecutorError)] | ||
| async fn data_stream(stream: BoxTryStream<M>) { |
There was a problem hiding this comment.
This looks like a no-op for FusedStreams. So I removed it.
There was a problem hiding this comment.
I also don't know why we need to do so before.
Signed-off-by: Bugen Zhao <[email protected]>
4 tasks
stdrc
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduce dedicated error type
DmlErrorfordmlcrate, to clean-up the usage ofanyhowandRwError. Also change the signature ofStreamReaderWithPauseto accept any streams that yieldsErr = StreamExecutorErrorinstead ofRwError.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.