-
Notifications
You must be signed in to change notification settings - Fork 640
feat(udf): support implicit cast for UDF arguments #14338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
Signed-off-by: Kevin Axel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: Kevin Axel <[email protected]> Co-authored-by: Zihao Xu <[email protected]> Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Kevin Axel <[email protected]> Signed-off-by: Runji Wang <[email protected]> Co-authored-by: Kevin Axel <[email protected]> Co-authored-by: Zihao Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might also update sql_udf.slt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this, no worries. 😄
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR resolves #9998. udf functions now support implicit cast.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.