Skip to content

support implicit cast for UDF arguments #9998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #7405
wangrunji0408 opened this issue May 25, 2023 · 1 comment · Fixed by #14338
Closed
Tracked by #7405

support implicit cast for UDF arguments #9998

wangrunji0408 opened this issue May 25, 2023 · 1 comment · Fixed by #14338
Assignees
@KveinAxel
Labels
C-expr Component: Scalar function, operator, expression framework. open to contribution Issues that are open to contribution.
Milestone
release-1.6

Comments

@wangrunji0408
Copy link
Contributor 

          Do we intend to support implicit cast of arguments or require explicit cast? For example, given a builtin `sind(double precision) -> double precision`, we can write `sind(30)`. But if that was a udf we have to write `sind_udf(30::double precision)` right now.

Originally posted by @xiangjinwu in #7405 (comment)
@wangrunji0408 wangrunji0408 self-assigned this May 25, 2023
@github-actions github-actions bot added this to the release-0.20 milestone May 25, 2023
@wangrunji0408 wangrunji0408 mentioned this issue May 25, 2023
Closed
26 tasks
@xxchan
Copy link
Member

xxchan commented Jul 6, 2023

A little note: the entry point of implicit cast seems to be FunctionCall::new (quite mysterious piece of work).

@xxchan xxchan mentioned this issue Jul 12, 2023
Closed
@TennyZhuang TennyZhuang modified the milestones: release-1.2, release-1.3 Sep 11, 2023
@wangrunji0408 wangrunji0408 mentioned this issue Nov 2, 2023
Closed
@wangrunji0408 wangrunji0408 modified the milestones: release-1.4, release-1.5 Nov 2, 2023
@wangrunji0408 wangrunji0408 modified the milestones: release-1.5, release-1.6 Dec 5, 2023
@fuyufjh fuyufjh added open to contribution Issues that are open to contribution. C-expr Component: Scalar function, operator, expression framework. labels Dec 19, 2023
@wangrunji0408 wangrunji0408 mentioned this issue Dec 28, 2023
Merged
9 tasks
@KveinAxel KveinAxel mentioned this issue Jan 3, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KveinAxel KveinAxel

Labels
C-expr Component: Scalar function, operator, expression framework. open to contribution Issues that are open to contribution.
Projects
None yet
Milestone
release-1.6
Development

Successfully merging a pull request may close this issue.

feat(udf): support implicit cast for UDF arguments risingwavelabs/risingwave
5 participants
@TennyZhuang @fuyufjh @wangrunji0408 @xxchan @KveinAxel