Skip to content

feat(meta): add system parameter pause_on_next_bootstrap (cherry-pick #11936) #12053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/feature Type: New feature. label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #12053 (01e25b4) into v1.2-rc (ffa7e89) will decrease coverage by 0.04%.
The diff coverage is 47.58%.

❗ Current head 01e25b4 differs from pull request most recent head f53f65f. Consider uploading reports for the commit f53f65f to get more accurate results

@@             Coverage Diff             @@
##           v1.2-rc   #12053      +/-   ##
===========================================
- Coverage    69.83%   69.79%   -0.04%     
===========================================
  Files         1396     1396              
  Lines       234391   234398       +7     
===========================================
- Hits        163683   163605      -78     
- Misses       70708    70793      +85     
Flag Coverage Δ
rust 69.79% <47.58%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/meta/src/barrier/schedule.rs 80.93% <0.00%> (-0.97%) ⬇️
src/meta/src/rpc/service/scale_service.rs 0.00% <0.00%> (ø)
src/meta/src/stream/scale.rs 10.51% <0.00%> (ø)
src/meta/src/stream/stream_manager.rs 74.01% <0.00%> (ø)
src/stream/src/executor/dml.rs 89.47% <ø> (ø)
...c/stream/src/executor/source/fs_source_executor.rs 0.00% <ø> (ø)
src/meta/src/barrier/command.rs 34.47% <28.94%> (-0.85%) ⬇️
src/stream/src/executor/mod.rs 47.57% <33.33%> (-0.45%) ⬇️
src/meta/src/model/barrier.rs 76.00% <60.00%> (-24.00%) ⬇️
src/meta/src/barrier/recovery.rs 52.56% <61.11%> (-0.10%) ⬇️
... and 8 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao BugenZhao enabled auto-merge (squash) September 4, 2023 07:15
@BugenZhao BugenZhao merged commit 6b8f38a into v1.2-rc Sep 4, 2023
@BugenZhao BugenZhao deleted the bz/cherry-pick-11936 branch September 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Type: New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants