-
Notifications
You must be signed in to change notification settings - Fork 640
feat(meta): add system parameter pause_on_next_bootstrap
#11936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Will write a deterministic test to cover this. |
Signed-off-by: Bugen Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 4023 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1774 | 1 | 2248 | 0 |
Click to see the invalid file list
- src/tests/simulation/tests/integration_tests/recovery/pause_on_bootstrap.rs
src/tests/simulation/tests/integration_tests/recovery/pause_on_bootstrap.rs
Show resolved
Hide resolved
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #11936 +/- ##
==========================================
- Coverage 69.81% 69.80% -0.02%
==========================================
Files 1392 1392
Lines 233462 233510 +48
==========================================
+ Hits 162996 163006 +10
- Misses 70466 70504 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add system parameter
pause_on_next_bootstrap
. When set totrue
, the cluster will pause all data sources (including connectors and DMLs) on the next startup, then reset this value. This is for debugging and maintenance purposes.To resume the data, users have to run
risectl meta resume
, or simply restart the cluster again. We may introduce an SQL command to do this in the future.By introducing the
PausedReason
in the global barrier manager, the paused state won't be accidentally broken by theResume
stage of scaling, or creating a new streaming job.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
pause_on_next_bootstrap
. When set totrue
, the cluster will pause all data sources (including connectors and DMLs) on the next startup, then reset this value. This is for debugging and maintenance purposes.