Skip to content

fix(metrics): incorrect FP rate (#10300) #10404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix(metrics): incorrect FP rate (#10300) #10404

merged 1 commit into from
Jun 23, 2023

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

- [ ] My PR contains user-facing changes.

@lmatz lmatz requested a review from fuyufjh June 19, 2023 09:58
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #10404 (905a99b) into v0.19.0-rc (0c87f33) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 905a99b differs from pull request most recent head e134072. Consider uploading reports for the commit e134072 to get more accurate results

@@              Coverage Diff               @@
##           v0.19.0-rc   #10404      +/-   ##
==============================================
+ Coverage       70.94%   70.96%   +0.01%     
==============================================
  Files            1232     1231       -1     
  Lines          211107   210981     -126     
==============================================
- Hits           149779   149730      -49     
+ Misses          61328    61251      -77     
Flag Coverage Δ
rust 70.96% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added type/fix Type: Bug fix. Only for pull requests. user-facing-changes Contains changes that are visible to users labels Jun 19, 2023
@lmatz lmatz removed the user-facing-changes Contains changes that are visible to users label Jun 19, 2023
@lmatz lmatz merged commit 680d7ef into v0.19.0-rc Jun 23, 2023
@lmatz lmatz deleted the 10300 branch June 23, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant