Skip to content

Commit 680d7ef

Browse files
authored
fix(metrics): incorrect FP rate (#10300) (#10404)
1 parent 0c87f33 commit 680d7ef

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

docker/dashboards/risingwave-dev-dashboard.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/cpu-profiling.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ Share an easy-to-use profiler and flamegraph tool: https://github.com/koute/not-
66
Record samples:
77

88
```shell
9-
nperf record -p `pidof compute-node` -o perf.data`
9+
nperf record -p `pidof compute-node` -o perf.data
1010
```
1111

1212
Generate flamegraph:
1313

1414
```shell
15-
nperf flamegraph perf.data > perf.svg
15+
nperf flamegraph --merge-threads perf.data > perf.svg
1616
```
1717

1818
## Profiling remote compute nodes

grafana/risingwave-dev-dashboard.dashboard.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1807,7 +1807,7 @@ def section_hummock(panels):
18071807
"False-Positive / Positive",
18081808
[
18091809
panels.target(
1810-
f"1 - (((sum(rate({table_metric('state_store_read_req_positive_but_non_exist_counts')}[$__rate_interval])) by (job,instance,table_id,type))) / (sum(rate({table_metric('state_store_read_req_bloom_filter_positive_counts')}[$__rate_interval])) by (job,instance,table_id,type)))",
1810+
f"(((sum(rate({table_metric('state_store_read_req_positive_but_non_exist_counts')}[$__rate_interval])) by (job,instance,table_id,type))) / (sum(rate({table_metric('state_store_read_req_bloom_filter_positive_counts')}[$__rate_interval])) by (job,instance,table_id,type)))",
18111811
"read req bloom filter false positive rate - {{table_id}} - {{type}} @ {{job}} @ {{instance}}",
18121812
),
18131813
],

grafana/risingwave-dev-dashboard.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)