Fix mstatus fs/vs field descriptions #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkOpenly
approved these changes
May 5, 2025
dhower-qc
requested changes
May 5, 2025
There was a problem hiding this comment.
While we are at it, the extra_validation should also check that mstatus.FS is read-only if neither F nor S is implemented. Something like:
extra_validation: |
assert MSTATUS_FS_WRITEABLE == true if ext?(:F)
assert MSTATUS_FS_WRITEABLE == false if (!ext?(:S) && !ext?(:F))Same for VS.
|
Updated to add the new |
The existing description said "This parameter only has an effect when both S and F mode are disabled." This is incorrect. The field has an effect when F is disabled and S is enabled. We could update the description, but the preceding line makes this sentence redundant anyway, so this just removes the line instead. The same issue applies to the "vs" field. Also adds extra_validation to these parameters.
dhower-qc
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing description said
This is incorrect. The field has an effect when F is disabled and S is enabled. We could update the description, but the preceding line makes this sentence redundant anyway, so this just removes the line instead.
The same issue applies to the "vs" field.