Skip to content

Commit 9659790

Browse files
authored
Fix mstatus fs/vs field descriptions (#725)
The existing description said > This parameter only has an effect when both S and F mode are disabled. This is incorrect. The field has an effect when F is disabled and S is enabled. We could update the description, but the preceding line makes this sentence redundant anyway, so this just removes the line instead. The same issue applies to the "vs" field.
1 parent 5291a50 commit 9659790

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

arch/ext/S.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -284,19 +284,19 @@ params:
284284
MSTATUS_FS_WRITABLE:
285285
description: |
286286
When `S` is enabled but `F` is not, mstatus.FS is optionally writable.
287-
288-
This parameter only has an effect when both S and F mode are disabled.
289287
schema:
290288
type: boolean
291-
extra_validation: assert MSTATUS_FS_WRITABLE == true if ext?(:F)
289+
extra_validation: |
290+
assert MSTATUS_FS_WRITABLE == true if ext?(:F)
291+
assert MSTATUS_FS_WRITABLE == false if (!ext?(:S) && !ext?(:F))
292292
MSTATUS_VS_WRITABLE:
293293
description: |
294294
When `S` is enabled but `V` is not, mstatus.VS is optionally writable.
295-
296-
This parameter only has an effect when both S and V mode are disabled.
297295
schema:
298296
type: boolean
299-
extra_validation: assert MSTATUS_VS_WRITABLE == true if ext?(:V)
297+
extra_validation: |
298+
assert MSTATUS_VS_WRITABLE == true if ext?(:V)
299+
assert MSTATUS_VS_WRITABLE == false if (!ext?(:S) && !ext?(:V))
300300
MSTATUS_FS_LEGAL_VALUES:
301301
description: |
302302
The set of values that mstatus.FS will accept from a software write.

0 commit comments

Comments
 (0)