-
Notifications
You must be signed in to change notification settings - Fork 777
feat(react-email): No forced file extensions on slugs #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-email): No forced file extensions on slugs #1215
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Should we actually support extensions in the URL? How hard would be to not support it? |
When having |
@bukinoshita I don't think it would be hard but we'd need to change the links on the docs again through another PR maybe. Wdyt about that? |
Thank you so much @vcapretz! |
What was the issue?
Users were being forced into always having a
.tsx
at the end of the pathfor the preview app, this fixes that, meaning that if the user navigates around
between emails there won't be any
.tsx
, but if the user opens the URLwith an existing email and the right file extension, it will render correctly as well.
The latter remark from above is important because it means that we don't really
have to update the docs again to match these paths but the paths are still
going to look better for user experience.
How can I test to make sure it's fixed?
npx tsx ../../packages/react-email/src/cli/index.ts dev
inside of./apps/demo
.tsx
file extension on the URL