feat(react-email): Non-encoded email slugs #1203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
The preview app's pages for email previews were always encoding the slugs for emails
that had subdirectories making the user experience a bit worse and causing URLs to not
looks so pretty without any gain. The way I fixed this was just by using a catch-all router
for the
[slug]
page as[...slug]
and then giving the appropriate treatment to thepath segments.
This also has the added benefit of fixing the build process failing when the emails have
subdirectories. This fixes it because when generating the static parameters for the
[slug]
we forgot to implement the encoding of the characters for the URL.
How can I test to make its working?
npx tsx ../../packages/react-email/src/cli/index.ts dev
inside of./apps/demo
./apps/demo