Skip to content

Fix lint error from #9854 #9856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

Fix lint error from #9854 #9856

merged 3 commits into from
May 1, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented May 1, 2025

Fixes lint errors I let slip in #9854.

@abey79 abey79 added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ a355489 https://rerun.io/viewer/pr/9856 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 merged commit fba7990 into main May 1, 2025
36 checks passed
@abey79 abey79 deleted the antoine/fix-ci branch May 1, 2025 12:48
abey79 added a commit that referenced this pull request May 1, 2025
@abey79
Fix lint error from #9854 (#9856)
d0e0b95 
Fixes lint errors I let slip in #9854.
abey79 pushed a commit that referenced this pull request May 2, 2025
@jprochazk
Improve PR number parsing resiliency (#9860)
9333224 
This sort of thing failed before, because there were two PR numbers in
the title:
* [Fix lint error from #9854
(#9856)](fba7990)

Now it won't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abey79