-
Notifications
You must be signed in to change notification settings - Fork 451
Properly resolve component selectors in dataset index creation and search APIs #9854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jleibs
approved these changes
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
abey79
added a commit
that referenced
this pull request
May 1, 2025
abey79
added a commit
that referenced
this pull request
May 1, 2025
abey79
added a commit
that referenced
this pull request
May 1, 2025
…arch APIs (#9854) ### Related * Fixes #9837 * Further issue to address: * #9853 * #9855 ### What Initial attempt to formalise component column selector, how they are matched against a schema, and how they are expressed in our Python API. Applied on dataset index creation/search APIs. TODO: - [x] use `AnyComponentColumn` in APIs - [x] cleanup and fix type stubs --------- Co-authored-by: Jeremy Leibs <[email protected]>
abey79
added a commit
that referenced
this pull request
May 1, 2025
abey79
pushed a commit
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
AnyComponentColumn
toComponentColumnLike
in the python sdk #9853What
Initial attempt to formalise component column selector, how they are matched against a schema, and how they are expressed in our Python API. Applied on dataset index creation/search APIs.
TODO:
AnyComponentColumn
in APIs