Skip to content

Properly resolve component selectors in dataset index creation and search APIs #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Apr 30, 2025

Related

What

Initial attempt to formalise component column selector, how they are matched against a schema, and how they are expressed in our Python API. Applied on dataset index creation/search APIs.

TODO:

  •  use AnyComponentColumn in APIs
  • cleanup and fix type stubs

Copy link

github-actions bot commented Apr 30, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
7cd60ee https://rerun.io/viewer/pr/9854 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 added 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md dataplatform Rerun Data Platform integration labels Apr 30, 2025
@abey79 abey79 marked this pull request as ready for review May 1, 2025 10:01
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@abey79 abey79 merged commit 05f867c into main May 1, 2025
36 checks passed
@abey79 abey79 deleted the antoine/resolve-comp-selector branch May 1, 2025 11:21
abey79 added a commit that referenced this pull request May 1, 2025
@abey79 abey79 mentioned this pull request May 1, 2025
abey79 added a commit that referenced this pull request May 1, 2025
Fixes lint errors I let slip in #9854.
abey79 added a commit that referenced this pull request May 1, 2025
…arch APIs (#9854)

### Related

* Fixes #9837
* Further issue to address:
  * #9853
  * #9855 

### What

Initial attempt to formalise component column selector, how they are
matched against a schema, and how they are expressed in our Python API.
Applied on dataset index creation/search APIs.

TODO:
- [x] use `AnyComponentColumn` in APIs
- [x] cleanup and fix type stubs

---------

Co-authored-by: Jeremy Leibs <[email protected]>
abey79 added a commit that referenced this pull request May 1, 2025
Fixes lint errors I let slip in #9854.
@abey79 abey79 added include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 1, 2025
abey79 pushed a commit that referenced this pull request May 2, 2025
This sort of thing failed before, because there were two PR numbers in
the title:
* [Fix lint error from #9854
(#9856)](fba7990)

Now it won't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search APIs don't properly resolve Component Selector against remote schema
2 participants