re_protos: use async registration by default (protos) #9537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-reale
added
exclude from changelog
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
teh-cmc
approved these changes
Apr 9, 2025
crates/store/re_protos/proto/rerun/v1alpha1/manifest_registry.proto
Outdated
Show resolved
Hide resolved
crates/store/re_protos/proto/rerun/v1alpha1/manifest_registry.proto
Outdated
Show resolved
Hide resolved
crates/store/re_protos/proto/rerun/v1alpha1/manifest_registry.proto
Outdated
Show resolved
Hide resolved
|
Update: demo team says we can merge things at will |
andrea-reale
force-pushed
the
andrea/frontend_register_async
branch
2 times, most recently
from
adaa3ea to
50d3153
Compare
Signed-off-by: Andrea Reale <[email protected]>
andrea-reale
force-pushed
the
andrea/frontend_register_async
branch
from
50d3153 to
3efc862
Compare
andrea-reale
added a commit
that referenced
this pull request
Apr 14, 2025
…`register_with_dataset` (#9590) ### Related * Related to: rerun-io/dataplatform#527 * Follows: * #9537 * rerun-io/dataplatform#543 ### What In rerun-io/dataplatform#543, we replaced the synchronous register_with_dataset endpoint with an asynchronous equivalent. The python client, however, expects the endpoint to be synchronous. This change is a quick-fix to make the python client block for dataset registration task completion so that current user should not feel the difference. We should improve this in the future by exposing the asynchronous nature of the endpoint directly to the client. Signed-off-by: Andrea Reale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Make async dataset and partition registrations the default registration method for redap. Keep supporting synchronous registration via the ManifestRegistry direct endpoint only.