Skip to content

Commit 3efc862

Browse files
committed
re_protos: use async registration by default (protos)
Signed-off-by: Andrea Reale <[email protected]>
1 parent 02bda3e commit 3efc862

File tree

2 files changed

+57
-42
lines changed

2 files changed

+57
-42
lines changed

crates/store/re_protos/proto/rerun/v1alpha1/manifest_registry.proto

+13-9
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ import "rerun/v1alpha1/common.proto";
77
service ManifestRegistryService {
88
// --- Write data ---
99

10-
// Register new partitions with the Dataset
10+
// Register new partitions with the Dataset (asynchronously)
1111
rpc RegisterWithDataset(RegisterWithDatasetRequest) returns (RegisterWithDatasetResponse) {}
1212

13-
rpc RegisterWithDatasetAsync(RegisterWithDatasetAsyncRequest) returns (RegisterWithDatasetAsyncResponse) {}
13+
// Register new partitions with the Dataset (blocking)
14+
rpc RegisterWithDatasetBlocking(RegisterWithDatasetBlockingRequest) returns (RegisterWithDatasetBlockingResponse) {}
1415

1516
// Unimplemented.
1617
rpc WriteChunks(stream WriteChunksRequest) returns (stream WriteChunksResponse) {}
@@ -135,17 +136,20 @@ message RegisterWithDatasetRequest {
135136
}
136137

137138
message RegisterWithDatasetResponse {
138-
rerun.common.v1alpha1.DataframePart data = 1;
139+
rerun.common.v1alpha1.TaskId id = 1;
139140
}
140141

141-
message RegisterWithDatasetAsyncRequest {
142-
// today this just wraps the sync request. This at least avoids
143-
// repetition and the two messages going out of sync.
144-
RegisterWithDatasetRequest request = 1;
142+
// TODO(andrea): This is a copy of RegisterWithDatasetRequest.
143+
// Eventually we _may_ get rid of the sync version; until then,
144+
// we should make sure that the two objects are in sync.
145+
message RegisterWithDatasetBlockingRequest {
146+
rerun.common.v1alpha1.DatasetHandle entry = 1;
147+
repeated DataSource data_sources = 2;
148+
rerun.common.v1alpha1.IfDuplicateBehavior on_duplicate = 3;
145149
}
146150

147-
message RegisterWithDatasetAsyncResponse {
148-
rerun.common.v1alpha1.TaskId id = 1;
151+
message RegisterWithDatasetBlockingResponse {
152+
rerun.common.v1alpha1.DataframePart data = 1;
149153
}
150154

151155
message WriteChunksRequest {

crates/store/re_protos/src/v1alpha1/rerun.manifest_registry.v1alpha1.rs

+44-33
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)