@@ -7,10 +7,11 @@ import "rerun/v1alpha1/common.proto";
7
7
service ManifestRegistryService {
8
8
// --- Write data ---
9
9
10
- // Register new partitions with the Dataset
10
+ // Register new partitions with the Dataset (asynchronously)
11
11
rpc RegisterWithDataset (RegisterWithDatasetRequest ) returns (RegisterWithDatasetResponse ) {}
12
12
13
- rpc RegisterWithDatasetAsync (RegisterWithDatasetAsyncRequest ) returns (RegisterWithDatasetAsyncResponse ) {}
13
+ // Register new partitions with the Dataset (blocking)
14
+ rpc RegisterWithDatasetBlocking (RegisterWithDatasetBlockingRequest ) returns (RegisterWithDatasetBlockingResponse ) {}
14
15
15
16
// Unimplemented.
16
17
rpc WriteChunks (stream WriteChunksRequest ) returns (stream WriteChunksResponse ) {}
@@ -135,17 +136,20 @@ message RegisterWithDatasetRequest {
135
136
}
136
137
137
138
message RegisterWithDatasetResponse {
138
- rerun.common.v1alpha1.DataframePart data = 1 ;
139
+ rerun.common.v1alpha1.TaskId id = 1 ;
139
140
}
140
141
141
- message RegisterWithDatasetAsyncRequest {
142
- // today this just wraps the sync request. This at least avoids
143
- // repetition and the two messages going out of sync.
144
- RegisterWithDatasetRequest request = 1 ;
142
+ // TODO(andrea): This is a copy of RegisterWithDatasetRequest.
143
+ // Eventually we _may_ get rid of the sync version; until then,
144
+ // we should make sure that the two objects are in sync.
145
+ message RegisterWithDatasetBlockingRequest {
146
+ rerun.common.v1alpha1.DatasetHandle entry = 1 ;
147
+ repeated DataSource data_sources = 2 ;
148
+ rerun.common.v1alpha1.IfDuplicateBehavior on_duplicate = 3 ;
145
149
}
146
150
147
- message RegisterWithDatasetAsyncResponse {
148
- rerun.common.v1alpha1.TaskId id = 1 ;
151
+ message RegisterWithDatasetBlockingResponse {
152
+ rerun.common.v1alpha1.DataframePart data = 1 ;
149
153
}
150
154
151
155
message WriteChunksRequest {
0 commit comments