Skip to content

Do not assert on Container type in compare_snippet_output #9275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2025
Merged

Do not assert on Container type in compare_snippet_output #9275

merged 6 commits into from
Mar 14, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Mar 13, 2025

This assert was introduced in #9260 and is apparently failing in CI. I'm really not sure why, but anyways it's replaced by a cast now.

@abey79 abey79 added 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Mar 13, 2025
@abey79
Copy link
Member Author

abey79 commented Mar 13, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13837166687

@abey79
Copy link
Member Author

abey79 commented Mar 13, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 00a998d https://rerun.io/viewer/pr/9275 +nightly +main

Note: This comment is updated whenever you push a commit.

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13839471919

@abey79
Copy link
Member Author

abey79 commented Mar 13, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13840287921

@teh-cmc
Copy link
Member

teh-cmc commented Mar 14, 2025

(full check failed)

@Wumpf Wumpf self-requested a review March 14, 2025 09:17
@Wumpf
Copy link
Member

Wumpf commented Mar 14, 2025

it still really likes __init__ 🤔

@abey79
Copy link
Member Author

abey79 commented Mar 14, 2025

it still really likes __init__ 🤔

I need to bite the bullet and actually test this thing locally 😅

@abey79
Copy link
Member Author

abey79 commented Mar 14, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13855316229

@abey79
Copy link
Member Author

abey79 commented Mar 14, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13855776527

@abey79
Copy link
Member Author

abey79 commented Mar 14, 2025

Finally 🎉

@Wumpf Wumpf merged commit 6630ff7 into main Mar 14, 2025
75 checks passed
@Wumpf Wumpf deleted the antoine/no-assert-container branch March 14, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release 🚢 CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abey79 @teh-cmc @Wumpf