Never drop blueprint data from the WS server's message buffer #8977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DerpDays <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
teh-cmc
changed the title
teh-cmc
added
🪳 bug
|
That's exactly the right fix, thanks! Note for others reading: this does not log the blueprint as static, which would be very scary, it's just more websocket server buffer shenanigans. |
teh-cmc
approved these changes
Feb 10, 2025
Closed
oxkitsune
pushed a commit
that referenced
this pull request
Feb 19, 2025
### Related * Closes #8741 ### What Makes blueprint contents be saved internally as static (along with their activation command), instead of as a normal message. This fixes the issue with default blueprints not being activated on web clients when a new user connects, since after this change blueprint data is also saved as static, this means the blueprint data is now sent to the client before the activation command (since the activation command is read and sent to the sink after the blueprint data). More info can be found in the related issue [#8741](#8741 (comment)). Edit: just seen that there is plans to move away from websockets to gRPC so this will probably be irrelevant soon. Signed-off-by: DerpDays <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
make_activedoesn't work with the web viewer #8741What
Makes blueprint contents be saved internally as static (along with their activation command), instead of as a normal message.
This fixes the issue with default blueprints not being activated on web clients when a new user connects, since after this change blueprint data is also saved as static, this means the blueprint data is now sent to the client before the activation command (since the activation command is read and sent to the sink after the blueprint data).
More info can be found in the related issue #8741.
Edit: just seen that there is plans to move away from websockets to gRPC so this will probably be irrelevant soon.