-
Notifications
You must be signed in to change notification settings - Fork 451
Migrate SDK comms to gRPC #8838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead, move dataplatform-related stuff into `redap` and feature gate that behind a separate feature flag. Message proxy client is now always available.
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
We should apply this fix too: |
I'm not sure if it applies here. I explicitly added The question is whether or not we want to garbage collect blueprints in the first place. It's reasonable to say that we don't, because it's not a ton of data compared to an actual recording. |
Previously, all blueprint data, including activation commands, would be garbage collected. It doesn't make much sense, because blueprints use very little memory compared to the rest of a typical recording.
I ended up doing just that, so we no longer GC blueprints at all |
This way we can individually evolve those types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I'm sure there are some edge-cases that are only going to turn up in testing.
The biggest potential API-regression I see is the loss of flush_timeout
behavior -- it's not totally clear to me under what circumstances data potentially gets dropped if the connection between the client and server is broken before we call flush.
Co-authored-by: Jeremy Leibs <[email protected]>
One last check before merge @rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13251249033 |
Related
What
The goal of this PR is to completely delete
re_sdk_comms
andre_ws_comms
. The prerequisite to this is to first migrate all of their usages over to our temporary gRPC server ("message proxy").Step-by-step:
gRPC
variants ofspawn
/connect
from all SDKsre_ws_comms
server and connect to it by defaultre_sdk_comms
andre_ws_comms
re_sdk_comms
andre_ws_comms
I don't really know how to split this up, to be honest! There are tons of subtle but very strong dependencies between different parts of our SDKs, the Viewer, and the "server". Breaking it apart seems too difficult, and it'd also temporarily make some parts of rerun unusable, and thus untestable. So instead I'll be trying to keep individual commits somewhat sensible and reviewable.
Testing checklist
spawn
serve
rerun
(default args) + SDKconnect
rerun --web-viewer
+ SDKconnect