Skip to content

Warn on loading Geo* archetypes without the map_view feature #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2024
Merged

Warn on loading Geo* archetypes without the map_view feature #8061

merged 5 commits into from
Nov 11, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 11, 2024 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view labels Nov 11, 2024
abey79
abey79 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@emilk emilk merged commit 5aaf203 into main Nov 11, 2024
44 checks passed
@emilk emilk deleted the emilk/warn-when-there-is-no-map_view branch November 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when Geo* entities are logged and the viewer wasn't compiled with the map_view feature
2 participants
@emilk @abey79