Warn when Geo* entities are logged and the viewer wasn't compiled with the map_view feature
#8052
Assignees
Labels
Comments
abey79
added
ui
6 tasks
emilk
added a commit
that referenced
this issue
Nov 11, 2024
### What * Closes #8052 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8061?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8061?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/8061) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
|
We log a warning, but that's not good enough. We should show the error message in the space view with the problem:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The map view is behind a
map_viewcargo feature onrerun-cli, which is enabled in release build but not in default build (aka when building from source). This leads to a footgun where people don't see a map when they expect one. We should warn the user when that happens, indicating that themap_viewfeature needs to be enabled.The proposed mechanism for that is to have a store subscribers that reacts to some specific indicator components, and emit warnings as required.
Level 1: hard code
GeoPointsandGeoLineStrings(subject to bitrot, eg when we introduceGeoPolygonsLevel 2: use the information already contained in
attribute.docs.view_typesto populate the reflection structures, and use said structure to generate warnings for all kinds of view that might be missing..
.
.
Level ∞: "unsupported data, click here to download the Map view plugin"
The text was updated successfully, but these errors were encountered: