Show what video frame is shown when hovering video in selection panel #7685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
ui
emilk
commented
Oct 11, 2024
Comment on lines
-30
to
-36
| let secs_int = n % 60; | ||
| let secs_hundredth = (timestamp_seconds.fract() * 100.0) as u32; | ||
| let secs = (n % 60) as f64 + timestamp_seconds.fract(); | ||
|
|
||
| if hours > 0 { | ||
| format!("{hours:02}:{mins:02}:{secs_int:02}.{secs_hundredth:02}") | ||
| format!("{hours:02}:{mins:02}:{secs:02.02}") | ||
| } else { | ||
| format!("{mins:02}:{secs_int:02}.{secs_hundredth:02}") |
There was a problem hiding this comment.
While experimenting I wanted to bump up the number of decimals, and the new code makes that a lot easier
Wumpf
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.