Skip to content

Make sure we present the right video frame at the right time #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emilk opened this issue Oct 9, 2024 · 2 comments
Closed

Make sure we present the right video frame at the right time #7647

emilk opened this issue Oct 9, 2024 · 2 comments
Labels
🔨 testing testing and benchmarks 🎞️ video

Comments

@emilk
Copy link
Member

emilk commented Oct 9, 2024

We currently use latest-at semantics for selecting the current video frame.

However, this is prone to rounding errors.

We should have some sort of test that we are indeed presenting exactly the right frame when the user selects an exact time point.

We could consider adding a small bias to avoid the rounding errors, or switch to closest-at. Neither solution is very attractive.
@emilk emilk added 🎞️ video 🔨 testing testing and benchmarks labels Oct 9, 2024
@emilk emilk changed the title video testing: make sure we present the right frame at the right time Make sure we present the right video frame at the right time Oct 9, 2024
@emilk emilk self-assigned this Oct 10, 2024
@emilk emilk mentioned this issue Oct 11, 2024
Merged
6 tasks
@emilk emilk removed their assignment Oct 11, 2024
Wumpf pushed a commit that referenced this issue Oct 11, 2024
@emilk
Show what video frame is shown when hovering video in selection panel (…
b248c88 
…#7685)

### What
* Part of #7647

<img width="299" alt="Screenshot 2024-10-11 at 09 12 23"
src="https://github.com/user-attachments/assets/37491c98-7329-4077-8057-14b487008636">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7685?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7685?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7685)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk
Copy link
Member Author

emilk commented Oct 20, 2024

This seems to be a problem on Safari, and maybe elsewhere too: https://x.com/chrisoffner3d/status/1847625953544966249

@Wumpf
Copy link
Member

Wumpf commented Oct 31, 2024 •
edited
Loading

Acquired much better understanding of this by now, giving rise to three new bugs, each of which are separate issues to my understanding:

@Wumpf Wumpf closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 testing testing and benchmarks 🎞️ video
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilk @Wumpf