Skip to content

Refactor native video decoder for code reuse #7641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 8, 2024

What

This refactors the native decoder so that we can easily slot in a different native decoder (ffmpeg!).

The innermost trait is now SyncDecoder which gets pushed a chunk, and blocks while producing frames (or errors). Around that is an AsyncDecoder that runs the SyncDecoder on a background thread to produce a non-blocking interface.
Finally in re_renderer there is the NativeDecoder that wraps SyncDecoder and handles texture uploads.

There is a lot of code moved, but very little code actually changed. It's just another layer of abstraction introduced.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 8, 2024
@Wumpf Wumpf self-requested a review October 8, 2024 18:06
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well threaded in 😁
We're starting to see a nice hierarchy of decoder wrangling logic. Let's hope we don't regret this and have to add holes through these nice abstractions, but so far I'm very optimistic on that!

impl NativeDecoder {
pub fn new(
debug_name: String,
sync_decoder: Box<dyn re_video::decode::SyncDecoder + Send>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found it odd at first that all NativeDecoders host a SyncDecoder internally. But from the looks of it this gonna hold up at least for a a few weeks 😁 this is what we're dealing with :)

@emilk emilk merged commit d90a697 into main Oct 8, 2024
33 checks passed
@emilk emilk deleted the emilk/refactor-native-decoder branch October 8, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants