Refactor native video decoder for code reuse #7641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This refactors the native decoder so that we can easily slot in a different native decoder (ffmpeg!).
The innermost trait is now
SyncDecoder
which gets pushed a chunk, and blocks while producing frames (or errors). Around that is anAsyncDecoder
that runs theSyncDecoder
on a background thread to produce a non-blocking interface.Finally in
re_renderer
there is theNativeDecoder
that wrapsSyncDecoder
and handles texture uploads.There is a lot of code moved, but very little code actually changed. It's just another layer of abstraction introduced.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.