Skip to content

Add force_querystring argument to fetch_token() method #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

Add force_querystring argument to fetch_token() method #369

merged 1 commit into from
Mar 21, 2019

Conversation

singingwolfboy
Copy link
Member

Based on #361

@coveralls
Copy link

coveralls commented Feb 25, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.495% when pulling 8d9b7a7 on singingwolfboy:force-querystring into c80b2b6 on requests:master.

This was referenced Feb 26, 2019
Closed
Open
AdamGold
AdamGold suggested changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@AdamGold AdamGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want the same force_querystring logic in refresh_token?

@singingwolfboy
Copy link
Member Author

We can do that in a future pull request. I spent some time trying to figure out how to write tests for it, and I wasn't able to do it. The test harness needs a big overhaul.

@singingwolfboy singingwolfboy merged commit 800976f into requests:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamGold AdamGold AdamGold requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@singingwolfboy @coveralls @AdamGold