Skip to content

add option to pass params in POST request #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AdamGold
Copy link
Contributor

@AdamGold AdamGold commented Jan 27, 2019

  • add tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 89.697% when pulling 23ec79d on AdamGold:feature/params-requests into 1495328 on requests:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 89.697% when pulling 23ec79d on AdamGold:feature/params-requests into 1495328 on requests:master.

@coveralls
Copy link

coveralls commented Jan 27, 2019

Coverage Status

Coverage decreased (-0.08%) to 89.858% when pulling ba3aaf3 on AdamGold:feature/params-requests into 1495328 on requests:master.

@AdamGold AdamGold force-pushed the feature/params-requests branch from 23ec79d to 40456f7 Compare January 27, 2019 11:58
@singingwolfboy
Copy link
Member

It looks like there's a lot of changes in this commit that are just about reformatting code. Can you put those in a separate commit, or even better, a separate pull request? That will make it easier to review this, as well as easier to look through the Git history to find out how this project changed over time.

@AdamGold AdamGold force-pushed the feature/params-requests branch from 40456f7 to b7daf49 Compare January 27, 2019 20:47
@AdamGold AdamGold force-pushed the feature/params-requests branch from b7daf49 to ba3aaf3 Compare January 27, 2019 20:51
@AdamGold
Copy link
Contributor Author

@singingwolfboy Absolutely! My bad. All done.

@AdamGold AdamGold changed the title add option to pass params in POST request for networks like Instagram add option to pass params in POST request Jan 30, 2019
@singingwolfboy
Copy link
Member

This pull request is still full of formatting changes. I've tried to pull the actual code changes out into a separate pull request: #369. Could you please review that, and tell me if it solves your problem?

@AdamGold
Copy link
Contributor Author

Looking at the changes there are really only 2 formatting changes I can spot. There are some lines that it looks like a formatting change but it's actually a parameter addition or something. Anyways, I'll take a look at your PR! :)

@singingwolfboy
Copy link
Member

There are some lines that it looks like a formatting change but it's actually a parameter addition or something.

Yes, this is precisely the reason I asked you to separate the formatting changes from the code changes. When you mix the two, it becomes harder to understand what is being changed, and why.

I merged #368 to make this easier in the future.

@AdamGold AdamGold closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants