-
-
Notifications
You must be signed in to change notification settings - Fork 420
add option to pass params
in POST request
#361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AdamGold
commented
Jan 27, 2019
•
edited
Loading
edited
- add tests
1 similar comment
23ec79d
to
40456f7
Compare
It looks like there's a lot of changes in this commit that are just about reformatting code. Can you put those in a separate commit, or even better, a separate pull request? That will make it easier to review this, as well as easier to look through the Git history to find out how this project changed over time. |
40456f7
to
b7daf49
Compare
b7daf49
to
ba3aaf3
Compare
@singingwolfboy Absolutely! My bad. All done. |
params
in POST request for networks like Instagramparams
in POST request
This pull request is still full of formatting changes. I've tried to pull the actual code changes out into a separate pull request: #369. Could you please review that, and tell me if it solves your problem? |
Looking at the changes there are really only 2 formatting changes I can spot. There are some lines that it looks like a formatting change but it's actually a parameter addition or something. Anyways, I'll take a look at your PR! :) |
Yes, this is precisely the reason I asked you to separate the formatting changes from the code changes. When you mix the two, it becomes harder to understand what is being changed, and why. I merged #368 to make this easier in the future. |