Skip to content

fix(changelogs): support massaging self-hosted gitlab URLs #35258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Apr 8, 2025

Changes

This PR enables retrieving release notes from dependencies hosted on gitlab.com and self-hosted Gitlab instances.

Context

Without this PR, release notes from dependencies hosted on gitlab.com and self-hosted Gitlab instances are not retrieved as sourceUrl is left empty.

Discussion took place in #35123
This PR supersedes #35110 which was closed because discussion was missing, but I cannot re-open it.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title fix: prefer massaged URL when source URL isn't HTTP(S) to support changelogs for non Github sources (take 2) fix(changelogs): support massaging self-hosted gitlab URLs Apr 8, 2025
@rarkins rarkins requested a review from viceice April 8, 2025 16:00
@rarkins rarkins enabled auto-merge April 8, 2025 16:00
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small improvement

@rarkins rarkins added this pull request to the merge queue Apr 8, 2025
Merged via the queue into renovatebot:main with commit 8a93407 Apr 8, 2025
40 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.235.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pdecat pdecat deleted the fix/gitlab_changelog branch April 8, 2025 18:26
@pdecat
Copy link
Contributor Author

pdecat commented Apr 8, 2025

Thanks! 🎉

SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request Apr 11, 2025
* upstream/main: (267 commits)
  chore(deps): update dependency @types/luxon to v3.6.2 (main) (renovatebot#35319)
  refactor(gerrit): remove deprecated source branch as hashtags support (renovatebot#33329)
  chore(deps): update dependency @types/luxon to v3.6.1 (main) (renovatebot#35313)
  chore(deps): update dependency type-fest to v4.39.1 (main) (renovatebot#35302)
  chore(deps): update dependency @types/node to v22.14.0 (main) (renovatebot#35295)
  chore(deps): update dependency @vitest/eslint-plugin to v1.1.39 (main) (renovatebot#35293)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.8.13 (main) (renovatebot#35289)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.8.13 (main) (renovatebot#35288)
  feat(datasource/github-runners): mark Windows Server 2025 as stable (renovatebot#35284)
  feat(bitbucket-server): add support for changelogs (renovatebot#34569)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.8.12 (main) (renovatebot#35279)
  fix(tool/pixi): remove `v` prefix from raw version (renovatebot#35277)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.8.12 (main) (renovatebot#35278)
  chore(deps): update dependency pdm to v2.23.1 (main) (renovatebot#35275)
  feat(conan): Add support for lockfile maintenance (renovatebot#28174)
  fix(changelogs): support massaging self-hosted gitlab URLs (renovatebot#35258)
  chore(deps): update dependency @types/node to v22.13.17 (main) (renovatebot#35263)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.8.11 (main) (renovatebot#35260)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.8.11 (main) (renovatebot#35259)
  refactor(circleci): Simplify CircleCI extraction (renovatebot#35233)
  ...
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Apr 14, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [data.forgejo.org/renovate/renovate](https://renovatebot.com) ([source](https://github.com/renovatebot/renovate)) | container | minor | `39.233.5` -> `39.240.1` |
| [renovate](https://renovatebot.com) ([source](https://github.com/renovatebot/renovate)) |  | minor | `39.233.5` -> `39.240.1` |

---

### Release Notes

<details>
<summary>renovatebot/renovate (data.forgejo.org/renovate/renovate)</summary>

### [`v39.240.1`](https://github.com/renovatebot/renovate/releases/tag/39.240.1)

[Compare Source](renovatebot/renovate@39.240.0...39.240.1)

##### Build System

-   **deps:** update dependency cronstrue to v2.58.0 (main) ([#&#8203;35346](renovatebot/renovate#35346)) ([7da63b4](renovatebot/renovate@7da63b4))

### [`v39.240.0`](https://github.com/renovatebot/renovate/releases/tag/39.240.0)

[Compare Source](renovatebot/renovate@39.238.2...39.240.0)

##### Features

-   **datasource/azure-pipelines-tasks:** add built-in tasks changelog url ([#&#8203;35325](renovatebot/renovate#35325)) ([5091b14](renovatebot/renovate@5091b14))

##### Miscellaneous Chores

-   **deps:** update dependency [@&#8203;types/better-sqlite3](https://github.com/types/better-sqlite3) to v7.6.13 (main) ([#&#8203;35333](renovatebot/renovate#35333)) ([05b3fc0](renovatebot/renovate@05b3fc0))
-   **deps:** update dependency renovatebot/github-action to v41.0.19 (main) ([#&#8203;35337](renovatebot/renovate#35337)) ([479886f](renovatebot/renovate@479886f))
-   **deps:** update dependency typescript to v5.8.3 (main) ([#&#8203;35336](renovatebot/renovate#35336)) ([abe1f18](renovatebot/renovate@abe1f18))
-   **deps:** update dependency vitest-mock-extended to v3.1.0 (main) ([#&#8203;35334](renovatebot/renovate#35334)) ([680e161](renovatebot/renovate@680e161))

### [`v39.238.2`](https://github.com/renovatebot/renovate/releases/tag/39.238.2)

[Compare Source](renovatebot/renovate@39.238.1...39.238.2)

##### Bug Fixes

-   **workers/auto-replace:** correctly handle prefix replacements ([#&#8203;35265](renovatebot/renovate#35265)) ([afd6415](renovatebot/renovate@afd6415))

##### Miscellaneous Chores

-   **deps:** update dependency [@&#8203;types/luxon](https://github.com/types/luxon) to v3.6.1 (main) ([#&#8203;35313](renovatebot/renovate#35313)) ([05ebbf3](renovatebot/renovate@05ebbf3))
-   **deps:** update dependency [@&#8203;types/luxon](https://github.com/types/luxon) to v3.6.2 (main) ([#&#8203;35319](renovatebot/renovate#35319)) ([790d0ea](renovatebot/renovate@790d0ea))
-   **deps:** update dependency [@&#8203;types/node](https://github.com/types/node) to v22.14.0 (main) ([#&#8203;35295](renovatebot/renovate#35295)) ([2188ebb](renovatebot/renovate@2188ebb))
-   **deps:** update dependency [@&#8203;vitest/eslint-plugin](https://github.com/vitest/eslint-plugin) to v1.1.39 (main) ([#&#8203;35293](renovatebot/renovate#35293)) ([043d665](renovatebot/renovate@043d665))
-   **deps:** update dependency type-fest to v4.39.1 (main) ([#&#8203;35302](renovatebot/renovate#35302)) ([21e1e6f](renovatebot/renovate@21e1e6f))

##### Code Refactoring

-   **gerrit:** remove deprecated source branch as hashtags support ([#&#8203;33329](renovatebot/renovate#33329)) ([e64ca6b](renovatebot/renovate@e64ca6b))

### [`v39.238.1`](https://github.com/renovatebot/renovate/releases/tag/39.238.1)

[Compare Source](renovatebot/renovate@39.238.0...39.238.1)

##### Bug Fixes

-   **deps:** update ghcr.io/containerbase/sidecar docker tag to v13.8.13 (main) ([#&#8203;35289](renovatebot/renovate#35289)) ([25eafdb](renovatebot/renovate@25eafdb))

##### Miscellaneous Chores

-   **deps:** update ghcr.io/containerbase/devcontainer docker tag to v13.8.13 (main) ([#&#8203;35288](renovatebot/renovate#35288)) ([e0b85f3](renovatebot/renovate@e0b85f3))

### [`v39.238.0`](https://github.com/renovatebot/renovate/releases/tag/39.238.0)

[Compare Source](renovatebot/renovate@39.237.0...39.238.0)

##### Features

-   **datasource/github-runners:** mark Windows Server 2025 as stable ([#&#8203;35284](renovatebot/renovate#35284)) ([ad5c45f](renovatebot/renovate@ad5c45f))

### [`v39.237.0`](https://github.com/renovatebot/renovate/releases/tag/39.237.0)

[Compare Source](renovatebot/renovate@39.236.2...39.237.0)

##### Features

-   **bitbucket-server:** add support for changelogs ([#&#8203;34569](renovatebot/renovate#34569)) ([68a66a0](renovatebot/renovate@68a66a0))

### [`v39.236.2`](https://github.com/renovatebot/renovate/releases/tag/39.236.2)

[Compare Source](renovatebot/renovate@39.236.1...39.236.2)

##### Bug Fixes

-   **deps:** update ghcr.io/containerbase/sidecar docker tag to v13.8.12 (main) ([#&#8203;35279](renovatebot/renovate#35279)) ([702f18f](renovatebot/renovate@702f18f))

### [`v39.236.1`](https://github.com/renovatebot/renovate/releases/tag/39.236.1)

[Compare Source](renovatebot/renovate@39.236.0...39.236.1)

##### Bug Fixes

-   **tool/pixi:** remove `v` prefix from raw version ([#&#8203;35277](renovatebot/renovate#35277)) ([e938454](renovatebot/renovate@e938454))

##### Miscellaneous Chores

-   **deps:** update dependency pdm to v2.23.1 (main) ([#&#8203;35275](renovatebot/renovate#35275)) ([78ecd13](renovatebot/renovate@78ecd13))
-   **deps:** update ghcr.io/containerbase/devcontainer docker tag to v13.8.12 (main) ([#&#8203;35278](renovatebot/renovate#35278)) ([84454cf](renovatebot/renovate@84454cf))

### [`v39.236.0`](https://github.com/renovatebot/renovate/releases/tag/39.236.0)

[Compare Source](renovatebot/renovate@39.235.4...39.236.0)

##### Features

-   **conan:** Add support for lockfile maintenance ([#&#8203;28174](renovatebot/renovate#28174)) ([564ee83](renovatebot/renovate@564ee83))

### [`v39.235.4`](https://github.com/renovatebot/renovate/releases/tag/39.235.4)

[Compare Source](renovatebot/renovate@39.235.3...39.235.4)

##### Bug Fixes

-   **changelogs:** support massaging self-hosted gitlab URLs ([#&#8203;35258](renovatebot/renovate#35258)) ([8a93407](renovatebot/renovate@8a93407))

##### Miscellaneous Chores

-   **deps:** update dependency [@&#8203;types/node](https://github.com/types/node) to v22.13.17 (main) ([#&#8203;35263](renovatebot/renovate#35263)) ([12ea7e1](renovatebot/renovate@12ea7e1))

### [`v39.235.3`](https://github.com/renovatebot/renovate/releases/tag/39.235.3)

[Compare Source](renovatebot/renovate@39.235.2...39.235.3)

##### Bug Fixes

-   **deps:** update ghcr.io/containerbase/sidecar docker tag to v13.8.11 (main) ([#&#8203;35260](renovatebot/renovate#35260)) ([e4eefde](renovatebot/renovate@e4eefde))

##### Miscellaneous Chores

-   **deps:** update dependency [@&#8203;types/luxon](https://github.com/types/luxon) to v3.6.0 (main) ([#&#8203;35236](renovatebot/renovate#35236)) ([3619702](renovatebot/renovate@3619702))
-   **deps:** update dependency [@&#8203;types/node](https://github.com/types/node) to v22.13.15 (main) ([#&#8203;35237](renovatebot/renovate#35237)) ([6fbcdb3](renovatebot/renovate@6fbcdb3))
-   **deps:** update dependency [@&#8203;types/node](https://github.com/types/node) to v22.13.16 (main) ([#&#8203;35246](renovatebot/renovate#35246)) ([781a9cf](renovatebot/renovate@781a9cf))
-   **deps:** update dependency pnpm to v10.7.1 (main) ([#&#8203;35249](renovatebot/renovate#35249)) ([b88a306](renovatebot/renovate@b88a306))
-   **deps:** update dependency type-fest to v4.39.0 (main) ([#&#8203;35250](renovatebot/renovate#35250)) ([d4da4a1](renovatebot/renovate@d4da4a1))
-   **deps:** update ghcr.io/containerbase/devcontainer docker tag to v13.8.11 (main) ([#&#8203;35259](renovatebot/renovate#35259)) ([f6f5f4e](renovatebot/renovate@f6f5f4e))
-   **deps:** update github/codeql-action action to v3.28.15 (main) ([#&#8203;35235](renovatebot/renovate#35235)) ([1de6ec9](renovatebot/renovate@1de6ec9))
-   **deps:** update python:3.13 docker digest to [`18ecbd0`](renovatebot/renovate@18ecbd0) (main) ([#&#8203;35243](renovatebot/renovate#35243)) ([1b6f9df](renovatebot/renovate@1b6f9df))
-   **deps:** update python:3.13 docker digest to [`aaf6d3c`](renovatebot/renovate@aaf6d3c) (main) ([#&#8203;35247](renovatebot/renovate#35247)) ([e9ba9fc](renovatebot/renovate@e9ba9fc))
-   **deps:** update vitest monorepo to v3.1.1 (main) ([#&#8203;35221](renovatebot/renovate#35221)) ([558809f](renovatebot/renovate@558809f))

##### Code Refactoring

-   **circleci:** Simplify CircleCI extraction ([#&#8203;35233](renovatebot/renovate#35233)) ([8c00b15](renovatebot/renovate@8c00b15))

### [`v39.235.2`](https://github.com/renovatebot/renovate/releases/tag/39.235.2)

[Compare Source](renovatebot/renovate@39.235.1...39.235.2)

##### Build System

-   **deps:** update dependency [@&#8203;renovatebot/osv-offline](https://github.com/renovatebot/osv-offline) to v1.6.5 (main) ([#&#8203;35232](renovatebot/renovate#35232)) ([fcc9b47](renovatebot/renovate@fcc9b47))

### [`v39.235.1`](https://github.com/renovatebot/renovate/releases/tag/39.235.1)

[Compare Source](renovatebot/renovate@39.235.0...39.235.1)

##### Build System

-   **deps:** update dependency luxon to v3.6.1 (main) ([#&#8203;35230](renovatebot/renovate#35230)) ([c91c875](renovatebot/renovate@c91c875))

### [`v39.235.0`](https://github.com/renovatebot/renovate/releases/tag/39.235.0)

[Compare Source](renovatebot/renovate@39.234.0...39.235.0)

##### Features

-   **schema:** Add utility for detecting circular data ([#&#8203;35223](renovatebot/renovate#35223)) ([5ad8030](renovatebot/renovate@5ad8030))

##### Miscellaneous Chores

-   **deps:** update github/codeql-action action to v3.28.14 (main) ([#&#8203;35220](renovatebot/renovate#35220)) ([a13f5da](renovatebot/renovate@a13f5da))
-   **label-actions:** capitalize Renovate brandname ([#&#8203;35222](renovatebot/renovate#35222)) ([b53f2a9](renovatebot/renovate@b53f2a9))

### [`v39.234.0`](https://github.com/renovatebot/renovate/releases/tag/39.234.0)

[Compare Source](renovatebot/renovate@39.233.6...39.234.0)

##### Features

-   add Azure Pipelines preset ([#&#8203;35207](renovatebot/renovate#35207)) ([4cb2bb2](renovatebot/renovate@4cb2bb2))
-   **manager/nuget:** extract msbuild sdk from `Import` ([#&#8203;35206](renovatebot/renovate#35206)) ([727792a](renovatebot/renovate@727792a))

##### Documentation

-   **upgrade best practices:** update preset code plus small rewrite ([#&#8203;34837](renovatebot/renovate#34837)) ([0be280b](renovatebot/renovate@0be280b))

### [`v39.233.6`](https://github.com/renovatebot/renovate/releases/tag/39.233.6)

[Compare Source](renovatebot/renovate@39.233.5...39.233.6)

##### Bug Fixes

-   **circleci:** Ignore non-image alias items ([#&#8203;35212](renovatebot/renovate#35212)) ([e746331](renovatebot/renovate@e746331))

##### Documentation

-   update references to renovate/renovate (main) ([#&#8203;35213](renovatebot/renovate#35213)) ([73c9fac](renovatebot/renovate@73c9fac))

##### Miscellaneous Chores

-   **deps:** lock file maintenance (main) ([#&#8203;35214](renovatebot/renovate#35214)) ([3598dfb](renovatebot/renovate@3598dfb))
-   **deps:** lock file maintenance (main) ([#&#8203;35217](renovatebot/renovate#35217)) ([57972f6](renovatebot/renovate@57972f6))
-   **deps:** update containerbase/internal-tools action to v3.10.19 (main) ([#&#8203;35215](renovatebot/renovate#35215)) ([60ef7bf](renovatebot/renovate@60ef7bf))
-   **deps:** update containerbase/internal-tools action to v3.10.20 (main) ([#&#8203;35218](renovatebot/renovate#35218)) ([7cc1fb2](renovatebot/renovate@7cc1fb2))
-   **deps:** update dependency esbuild to v0.25.2 (main) ([#&#8203;35210](renovatebot/renovate#35210)) ([1107833](renovatebot/renovate@1107833))

##### Tests

-   **yaml:** Fix code block indents ([#&#8203;35211](renovatebot/renovate#35211)) ([5d48319](renovatebot/renovate@5d48319))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * 1" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzMuNSIsInVwZGF0ZWRJblZlciI6IjM5LjIzMy41IiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJmb3JnZWpvL2NpIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7532
Reviewed-by: Earl Warren <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants