Skip to content

Improve support for certain emojis in labels #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2024
Merged

Improve support for certain emojis in labels #49

merged 2 commits into from
Jun 23, 2024

Conversation

fregante
Copy link
Member

@fregante fregante commented Jun 23, 2024 •
edited
Loading

So it turns out this is not an issue with the shortener itself, but rather in how GitHub sets the href and textContent of the URLs.

href:
https://github.com/sindresorhus/refined-github/labels/Please%21%20♥%EF%B8%8E

text content:
https://github.com/sindresorhus/refined-github/labels/Please%21%20%E2%99%A5%EF%B8%8E

so the check in applyToLink does not pass (i.e. href and label don't match). This is why that link was not even being trimmed of https://

@fregante fregante linked an issue Jun 23, 2024 that may be closed by this pull request
Escape characters in labels #19
Closed
@fregante fregante merged commit e4fe9c8 into main Jun 23, 2024
6 checks passed
@fregante fregante changed the title Improve support for different label encodings Improve support for certain emojis in labels Jun 23, 2024
@fregante fregante deleted the encoded-labels branch June 23, 2024 06:45
This was referenced Jun 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escape characters in labels
1 participant
@fregante