Improve support for certain emojis in labels (#49)

Author: fregante

index.js

@@ -244,13 +244,24 @@ function shortenRepoUrl(href, currentUrl = 'https://github.com') {
 	return pathname.replaceAll(/^[/]|[/]$/g, '') + url.search + hash + query;
 }
 
+// Without this, <a>%%</a> would throw an error
+function safeDecode(url) {
+	try {
+		return decodeURIComponent(url);
+	} catch {
+		return url;
+	}
+}
+
 export function applyToLink(a, currentUrl) {
 	// Shorten only if the link name hasn't been customized.
 	// .href automatically adds a / to naked origins so that needs to be tested too
 	// `trim` makes it compatible with this feature: https://github.com/sindresorhus/refined-github/pull/3085
-	const url = a.dataset.originalHref ?? a.href;
+	// `safeDecode` is needed because some URLs are encoded in different ways in the DOM and in the `href` property: https://github.com/refined-github/shorten-repo-url/issues/19
+	const url = safeDecode(a.dataset.originalHref ?? a.href);
+	const label = safeDecode(a.textContent);
 	if (
-		(url === a.textContent.trim() || url === `${a.textContent}/`)
+		(url === label.trim() || url === `${label}/`)
 		&& !a.firstElementChild
 	) {
 		const shortened = shortenRepoUrl(url, currentUrl);

index.test.js

@@ -206,6 +206,10 @@ test('GitHub.com URLs', urlMatcherMacro, new Map([
 		'https://github.com/nodejs/node/labels/Please%21%20♥',
 		'nodejs/node/Please! ♥ (label)',
 	],
+	[
+		'https://github.com/refined-github/refined-github/labels/Please%21%20♥%EF%B8%8E',
+		'refined-github/refined-github/Please! ♥︎ (label)',
+	],
 	[
 		'https://github.com/fregante/shorten-repo-url/archive/6.4.1.zip',
 		'<code>6.4.1</code>.zip',