Add support for thecodingmachine/safe 2.4 #948

[tranvantri]

#948
Hi @mfn,

Could you please review this PR ?

Many thanks.

[mfn]

I had to remove it some time ago, see 0c52f7c

AFAICS, this still persists? Please check this failed workflow; there are a LOT of errors/noise so I'm talking specifically about this one https://github.com/rebing/graphql-laravel/actions/runs/3801830745/jobs/6537599565#step:8:11

Error: Function Safe\uksort not found.

Do you have any idea how to handle this?

[tranvantri]

Hi @mfn,

I added a function to check the compatible ability to use thecodingmachine/safe and checked it on PHP 7.4 and 8.1.

Could you please review this PR?

Many thanks.

[mfn]

• I've fixed the noise in master, can you please rebase?
• I've a feeling this approach won't work. phpstan analysis the code nevertheless and still will report it, see https://github.com/rebing/graphql-laravel/actions/runs/3847148887/jobs/6567331104#step:8:71 , it's still present

  Function Safe\uksort not found.

• (your code also reports style issues; run composer fix-style to fix them)

[mfn]

Nice, seems to work: all tests are green now!

---

Not fond of the change itself, but I guess there's no other way than a runtime check?

[tranvantri]

Hi @mfn,

I apologize for my inconvenience. Could you please review this PR?

Many thanks.

[tranvantri]

Nice, seems to work: all tests are green now!

Not fond of the change itself, but I guess there's no other way than a runtime check?

If we support both php version 7 and 8, then I think we can only check it on runtime. Another way is we will copy the \Safe\uksort into our Helpers and let us handle ourself.

[mfn]

Copying code over doesn't sound that much better 😔

Let's do it as suggested; we can remove it in the future once we drop 7.4 (no TTL yet)

[mfn]

Released as 8.5.0