Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for thecodingmachine/safe 2.0 #948

Closed
benrowe-chuffed opened this issue Sep 26, 2022 · 2 comments
Closed

Add support for thecodingmachine/safe 2.0 #948

benrowe-chuffed opened this issue Sep 26, 2022 · 2 comments

Comments

@benrowe-chuffed
Copy link

Summary

Please consider adding support for thecodingmachine/safe:^2.0.

Currently this package only supports ^1.3. Not only has 1.3 not been updated in two years, it's also missing support for PHP 8.

It's possible to support both since the 2.0 interfaces are backwards compatible AFAIK.

This can be done simply by changing the composer dependency to:

"require": {
  "thecodingmachine/safe": "^1.1 || ^2",
  ...
}
@mfn
Copy link
Collaborator

mfn commented Sep 27, 2022

LGTM, happy to accept a PR!

@mfn
Copy link
Collaborator

mfn commented Jan 13, 2023

Fixed with #961 and released as 8.5.0

@mfn mfn closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants