Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relationship alias #367

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Conversation

crissi
Copy link
Contributor

@crissi crissi commented Jul 1, 2019

added the possibilty to alias your relationships, great If integrating with legacy code or just need a more fancy output name.

Docs missing at this moment.

@crissi crissi force-pushed the added_relationship_alias branch from cb494a5 to 76f16fa Compare July 1, 2019 20:28
@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #367 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #367      +/-   ##
===========================================
+ Coverage     79.88%   79.9%   +0.02%     
  Complexity      333     333              
===========================================
  Files            23      23              
  Lines           880     881       +1     
===========================================
+ Hits            703     704       +1     
  Misses          177     177
Impacted Files Coverage Δ Complexity Δ
src/Support/SelectFields.php 77.14% <100%> (+0.16%) 80 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02aef4...e9f8b8d. Read the comment docs.

@mfn mfn force-pushed the added_relationship_alias branch from 88182ba to e9f8b8d Compare July 1, 2019 21:03
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Docs missing at this moment.

Not necessarily. I mean the alias is described how it works and it was never said it wouldn't work with relations; so I don't think an extra doc is required (though certainly nice).

I'll add a changelog later!

@mfn mfn merged commit e9f8b8d into rebing:master Jul 1, 2019
@mfn
Copy link
Collaborator

mfn commented Jul 1, 2019

I'll add a changelog later!

Done via 5317203 (unfortunately with a typo, will follow that up)

@mfn
Copy link
Collaborator

mfn commented Jul 2, 2019

@crissi btw, wanted to mention: before I saw your PR I worked on #366 and I actually did try to use alias to not have to create so many GraphQL types for various combinations; but I couldn't, because it didn't work.

Was about to go for a fix myself but luckily your PR came along and I now could already increase the coverage easily, see a05840f#diff-5cd9f61c1234f441bc613541c2135111R27

Pretty awesome how "planets aligned" here 👍 😄

mfn added a commit that referenced this pull request Jul 2, 2019
@crissi
Copy link
Contributor Author

crissi commented Jul 2, 2019 via email

believe2world added a commit to believe2world/graphql_admin_laravel that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants