-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added relationship alias #367
Conversation
cb494a5
to
76f16fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
===========================================
+ Coverage 79.88% 79.9% +0.02%
Complexity 333 333
===========================================
Files 23 23
Lines 880 881 +1
===========================================
+ Hits 703 704 +1
Misses 177 177
Continue to review full report at Codecov.
|
88182ba
to
e9f8b8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Docs missing at this moment.
Not necessarily. I mean the alias
is described how it works and it was never said it wouldn't work with relations; so I don't think an extra doc is required (though certainly nice).
I'll add a changelog later!
Done via 5317203 (unfortunately with a typo, will follow that up) |
@crissi btw, wanted to mention: before I saw your PR I worked on #366 and I actually did try to use alias to not have to create so many GraphQL types for various combinations; but I couldn't, because it didn't work. Was about to go for a fix myself but luckily your PR came along and I now could already increase the coverage easily, see a05840f#diff-5cd9f61c1234f441bc613541c2135111R27 Pretty awesome how "planets aligned" here 👍 😄 |
😊👍
Få Outlook til iOS<https://aka.ms/o0ukef>
…________________________________
Fra: Markus Podar <[email protected]>
Sendt: Tuesday, July 2, 2019 5:59:31 AM
Til: rebing/graphql-laravel
Cc: Christian; Mention
Emne: Re: [rebing/graphql-laravel] Added relationship alias (#367)
@crissi<https://github.com/crissi> btw, wanted to mention: before I saw your PR I worked on #366<#366> and I actually did try to use alias to not have to create so many GraphQL types for various combinations; but I couldn't, because it didn't work.
Was about to go for a fix myself but luckily your PR came along and I now could already increase the coverage easily, see a05840f#diff-5cd9f61c1234f441bc613541c2135111R27<a05840f#diff-5cd9f61c1234f441bc613541c2135111R27>
Pretty awesome how "planets aligned" here 👍 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#367?email_source=notifications&email_token=AAXPDYT77CA5UFLRWK6NES3P5LHCHA5CNFSM4H4VV2CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY77P7Y#issuecomment-507508735>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAXPDYU2WQ7BLTFVZ3CXWELP5LHCHANCNFSM4H4VV2CA>.
|
added the possibilty to alias your relationships, great If integrating with legacy code or just need a more fancy output name.
Docs missing at this moment.