Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELECTFIELDS] Fix always behaviour #366

Merged
merged 1 commit into from
Jul 1, 2019
Merged

[SELECTFIELDS] Fix always behaviour #366

merged 1 commit into from
Jul 1, 2019

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Jul 1, 2019

This probably got broken after #327 landed.

There were no tests before, so it didn't got noticed.

@mfn mfn self-assigned this Jul 1, 2019
@mfn mfn force-pushed the mfn-fix-always branch 2 times, most recently from 4777050 to 1fb4a3e Compare July 1, 2019 20:12
This _probably_ got broken after #327 landed.

There were no tests before, so it didn't got noticed.
@mfn mfn force-pushed the mfn-fix-always branch from 1fb4a3e to f02aef4 Compare July 1, 2019 20:20
@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #366 into master will increase coverage by 0.81%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
+ Coverage     79.06%   79.88%   +0.81%     
  Complexity      333      333              
============================================
  Files            23       23              
  Lines           879      880       +1     
============================================
+ Hits            695      703       +8     
+ Misses          184      177       -7
Impacted Files Coverage Δ Complexity Δ
src/Support/SelectFields.php 76.97% <100%> (+5.23%) 80 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e42b9...f02aef4. Read the comment docs.

@mfn mfn merged commit f02aef4 into master Jul 1, 2019
@mfn mfn deleted the mfn-fix-always branch July 1, 2019 20:57
@mfn mfn mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants