Download build artifacts from Github for CI #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
ajschmidt8
approved these changes
Apr 24, 2025
gmarkall
added a commit
to gmarkall/pynvjitlink
that referenced
this pull request
May 4, 2025
- Update to CUDA 12.9 (rapidsai#138) - feat(conda): port conda recipe to rattler-build (rapidsai#137) - Download build artifacts from Github for CI (rapidsai#136) - Moving wheel builds to specified location and uploading build artifacts to Github (rapidsai#135) - Use mainline shared-workflows again (rapidsai#134)
Merged
gmarkall
added a commit
that referenced
this pull request
May 4, 2025
- Update to CUDA 12.9 (#138) - feat(conda): port conda recipe to rattler-build (#137) - Download build artifacts from Github for CI (#136) - Moving wheel builds to specified location and uploading build artifacts to Github (#135) - Use mainline shared-workflows again (#134) <!-- Thank you for contributing to pynvjitlink :) Here are some guidelines to help the review process go smoothly. 1. Please write a description in this text box of the changes that are being made. 2. Please ensure that you have written units tests for the changes made/features added. 3. If you are closing an issue please use one of the automatic closing words as noted here: https://help.github.com/articles/closing-issues-using-keywords/ 4. If your pull request is not ready for review but you want to make use of the continuous integration testing facilities please label it with `[WIP]`. 5. If your pull request is ready to be reviewed without requiring additional work on top of it, then remove the `[WIP]` label (if present) and replace it with `[REVIEW]`. If assistance is required to complete the functionality, for example when the C/C++ code of a feature is complete but Python bindings are still required, then add the label `[HELP-REQ]` so that others can triage and assist. The additional changes then can be implemented on top of the same PR. If the assistance is done by members of the rapidsAI team, then no additional actions are required by the creator of the original PR for this, otherwise the original author of the PR needs to give permission to the person(s) assisting to commit to their personal fork of the project. If that doesn't happen then a new PR based on the code of the original PR can be opened by the person assisting, which then will be the PR that will be merged. 6. Once all work has been done and review has taken place please do not add features or make changes out of the scope of those requested by the reviewer (doing this just add delays as already reviewed code ends up having to be re-reviewed/it is hard to tell what is new etc!). Further, please do not rebase your branch on main/force push/rewrite history, doing any of these causes the context of any comments made by reviewers to be lost. If conflicts occur against main they should be resolved by merging main into the branch used for making the pull request. Many thanks in advance for your cooperation! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is towards moving build artifacts from
downloads.rapids.aito Github Artifact Store (see https://github.com/rapidsai/build-infra/issues/237)Updates conda and wheel artifact download source from S3 to GitHub across CI scripts, wherever applicable.
Uses dynamic temporary paths for wheel downloads returned by
rapids-download-wheels-from-githubinstead of using fixed directories, to streamline wheel downloads in the same way as conda downloads.Also updates CI workflows to follow
package-nameconvention between wheel build and wheel publish jobs.