Skip to content

Commit 0cd61a9

Browse files
Download build artifacts from Github for CI (#136)
This work is towards moving build artifacts from `downloads.rapids.ai` to Github Artifact Store (see https://github.com/rapidsai/ops/issues/2982) Updates conda and wheel artifact download source from S3 to GitHub across CI scripts, wherever applicable. Uses dynamic temporary paths for wheel downloads returned by `rapids-download-wheels-from-github` instead of using fixed directories, to streamline wheel downloads in the same way as conda downloads. Also updates CI workflows to follow `package-name` convention between wheel build and wheel publish jobs.
1 parent 857e95c commit 0cd61a9

File tree

5 files changed

+19
-19
lines changed

5 files changed

+19
-19
lines changed

.github/workflows/build.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,17 @@ jobs:
2525
build-wheels:
2626
needs:
2727
- compute-matrix
28-
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
28+
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.06
2929
with:
3030
build_type: branch
3131
script: "ci/build_wheel.sh"
3232
matrix_filter: ${{ needs.compute-matrix.outputs.BUILD_MATRIX }}
33-
wheel-name: pynvjitlink
33+
package-name: pynvjitlink
3434
package-type: python
3535
build-conda:
3636
needs:
3737
- compute-matrix
38-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
38+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.06
3939
with:
4040
build_type: branch
4141
script: "ci/build_conda.sh"
@@ -44,7 +44,7 @@ jobs:
4444
needs:
4545
- build-wheels
4646
secrets: inherit
47-
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@branch-25.04
47+
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@branch-25.06
4848
with:
4949
build_type: ${{ inputs.build_type || 'branch' }}
5050
branch: ${{ inputs.branch }}
@@ -56,7 +56,7 @@ jobs:
5656
needs:
5757
- build-conda
5858
secrets: inherit
59-
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@branch-25.04
59+
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@branch-25.06
6060
with:
6161
build_type: ${{ inputs.build_type || 'branch' }}
6262
branch: ${{ inputs.branch }}

.github/workflows/pr.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
- test-wheels
2222
- test-patch
2323
secrets: inherit
24-
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-25.04
24+
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-25.06
2525
checks:
2626
secrets: inherit
27-
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.04
27+
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.06
2828
with:
2929
enable_check_generated_files: false
3030
compute-matrix:
@@ -40,7 +40,7 @@ jobs:
4040
build-conda:
4141
needs:
4242
- compute-matrix
43-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
43+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.06
4444
with:
4545
build_type: pull-request
4646
script: "ci/build_conda.sh"
@@ -50,7 +50,7 @@ jobs:
5050
- build-conda
5151
- compute-matrix
5252
secrets: inherit
53-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
53+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.06
5454
with:
5555
build_type: pull-request
5656
script: "ci/test_conda.sh"
@@ -59,7 +59,7 @@ jobs:
5959
needs:
6060
- build-conda
6161
- compute-matrix
62-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
62+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.06
6363
with:
6464
build_type: pull-request
6565
script: "ci/test_patch.sh"
@@ -68,19 +68,19 @@ jobs:
6868
build-wheels:
6969
needs:
7070
- compute-matrix
71-
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
71+
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.06
7272
with:
7373
build_type: pull-request
7474
script: "ci/build_wheel.sh"
7575
matrix_filter: ${{ needs.compute-matrix.outputs.BUILD_MATRIX }}
76-
wheel-name: pynvjitlink
76+
package-name: pynvjitlink
7777
package-type: python
7878
test-wheels:
7979
needs:
8080
- build-wheels
8181
- compute-matrix
8282
secrets: inherit
83-
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.04
83+
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.06
8484
with:
8585
build_type: pull-request
8686
script: "ci/test_wheel.sh"

ci/test_conda.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# Copyright (c) 2024, NVIDIA CORPORATION
2+
# Copyright (c) 2024-2025, NVIDIA CORPORATION
33

44
set -euo pipefail
55

@@ -25,7 +25,7 @@ set +u
2525
conda activate test
2626
set -u
2727

28-
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)
28+
PYTHON_CHANNEL=$(rapids-download-conda-from-github python)
2929
RAPIDS_TESTS_DIR=${RAPIDS_TESTS_DIR:-"${PWD}/test-results"}/
3030
mkdir -p "${RAPIDS_TESTS_DIR}"
3131

ci/test_patch.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# Copyright (c) 2024, NVIDIA CORPORATION
2+
# Copyright (c) 2024-2025, NVIDIA CORPORATION
33

44
set -euo pipefail
55

@@ -23,7 +23,7 @@ set +u
2323
conda activate test
2424
set -u
2525

26-
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)
26+
PYTHON_CHANNEL=$(rapids-download-conda-from-github python)
2727

2828
rapids-print-env
2929

ci/test_wheel.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ set -euo pipefail
55

66
rapids-logger "Download Wheel"
77
RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen "${RAPIDS_CUDA_VERSION}")"
8-
RAPIDS_PY_WHEEL_NAME="pynvjitlink_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 ./dist/
8+
WHEELHOUSE=$(RAPIDS_PY_WHEEL_NAME="pynvjitlink_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-github python)
99

1010
RAPIDS_TESTS_DIR=${RAPIDS_TESTS_DIR:-"${PWD}/test-results"}/
1111
mkdir -p "${RAPIDS_TESTS_DIR}"
1212

1313
rapids-logger "Install wheel"
14-
rapids-pip-retry install "$(echo ./dist/pynvjitlink_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)[test]"
14+
rapids-pip-retry install "$(echo "${WHEELHOUSE}"/pynvjitlink_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)[test]"
1515

1616
rapids-logger "Build Tests"
1717
pushd test_binary_generation

0 commit comments

Comments
 (0)