Skip to content

allow '*' versions to match all #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ Package.prototype.updateRequired = function() {
var version = this.versionSpecified;
var isGitRepo = require('./git-repo');
var semver = require('semver');
if (isGitRepo(version)) {

if (version === '*') {
return false;
} else if (isGitRepo(version)) {
var parts = version.split('#');
if (parts.length === 2) {
version = semver.valid(parts[1]);
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"scripts": {
"start": "ember server",
"build": "ember build",
"test": "node tests/runner"
"test": "node tests/runner",
"test:debug": "node debug tests/runner"
},
"repository": {
"type": "git",
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/dependency-checker-bower-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,10 @@ describe('EmberCLIDependencyChecker', function() {
var project = createProject({ 'ember': '~/projects/emberjs' });
assertNoBowerError(project);
});

it('does NOT error with a * dependency', function() {
var project = createProject({ 'ember': '*' });
assertNoBowerError(project);
});
});
});
5 changes: 5 additions & 0 deletions tests/unit/dependency-checker-npm-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,10 @@ describe('EmberCLIDependencyChecker', function() {
var project = createProject({ 'ember-cli': '~/projects/ember-cli' });
assertNoNpmError(project);
});

it('does NOT error with a * dependency', function() {
var project = createProject({ 'ember-cli': '*' });
assertNoNpmError(project);
});
});
});