Skip to content

allow '*' versions to match all #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2015

Conversation

stefanpenner
Copy link
Collaborator

No description provided.

@stefanpenner
Copy link
Collaborator Author

@quaertym r?

Also, I would love to help you maintain this project. If you are interested let me know :)

@@ -92,5 +92,10 @@ describe('EmberCLIDependencyChecker', function() {
var project = createProject({ 'ember': '~/projects/emberjs' });
assertNoBowerError(project);
});

it('does error with a * dependency', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "does not error"

@stefanpenner
Copy link
Collaborator Author

Lame. Copy and paste. Will fix when I get home

@stefanpenner
Copy link
Collaborator Author

fixed.

quaertym added a commit that referenced this pull request Feb 25, 2015
allow '*' versions to match all
@quaertym quaertym merged commit 049e6c3 into quaertym:master Feb 25, 2015
@quaertym
Copy link
Owner

@stefanpenner

Also, I would love to help you maintain this project. If you are interested let me know :)

That would be great! 🍻

@stefanpenner stefanpenner deleted the splat-version branch February 25, 2015 14:28
@stefanpenner
Copy link
Collaborator Author

feel free to add me/rob to git + npm, so we can release and merge if you are busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants