-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-126562: Create package from shutil #130609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@picnixz what do you think? Should all of the functionality be available from the CLI? Is this even the right approach? |
Hi, please gather more consensus on DPO before opening a PR. A |
Hi Adam, You may not have noticed, but the DPO got nowhere, like most discussions there. A week of discussion and then it is forgotten - with no consensus in sight. This is largely due to the fact core devs, like yourself, do not participate. For this reason I drafted a minimal implementation like Benedkit had suggested, and which I agree with, and is consistent with the existing implementation of zipfiles cli. I think a reference implementation (This PR is a draft) may steer the discussion (bring it back from the grave) in the right direction. |
Also @jaraco may be interested |
DPO can be messy, I wouldn't put blame on anyone (especially core devs) for avoiding the ideas section. I agree with the |
I don't think that a command line interface (CLI) for shutil is a good idea. The scope of this module is too broad. You can maintain your own CLI on PyPI if you consider it useful to you. |
@vstinner will you close the issue then? A note on the thread would probably also be a good idea |
I close this PR since its issue was closed: #126562 |
Based on the existing zipfile cli implementation, work in progress.
The question is, what functionality do we add to the cli?
"copyfileobj",
"copyfile",
"copymode",
"copystat",
"copy",
"copy2",
"copytree",
"move",
rmtree",
"Error",
"SpecialFileError",
"make_archive",
"get_archive_formats",
"register_archive_format",
"unregister_archive_format",
"get_unpack_formats",
"register_unpack_format",
"unregister_unpack_format",
"unpack_archive",
"ignore_patterns",
"chown",
"which",
"get_terminal_size",
"SameFileError"
Feedback would be appreciated :-)