-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Turn shutil into a runnable module #126562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm pretty sure this needs to get discussed on DPO. |
Can't this be closed in the meantime? |
It could, but I don't see the need. It will just get reopened if we decide to go with the feature, and if not, then we'll close it. |
(Removing the pending label since we have now a discussion) |
Are we considering this approved? |
No, just that there is a discussion pending. In general, I consider |
FWIW, I think the DPO post was well received enough that submitting a PR isn't out of the question. Whether it gets merged is another thing, but the next logical step here is to actually implement it and see it in action. |
Hmm, although I don't see any support on DPO from a core team member, only one commented there with an alternative suggestion. |
Yeah, but TBF, core devs very rarely express interest in an idea there. The core team ultimately decides if it gets merged, anyway; DPO should be for gauging community interest. |
Now that a draft implementation is up, I'm bumping this to try and gather consensus, at least from Bénédikt and Hugo. In my eyes, the DPO thread went surprisingly well; it's relatively uncommon to get mostly-positive community feedback over there. Personally, I think this could be an interesting feature, but it's also not hitting that "gut feeling" for the standard library. (I'm not sure how to describe that--e.g., If there are any triagers or core devs that have a strong preference here, speak now or forever hold your peace! I'll close this in the next few days if there's nobody willing to second the PR. |
My read of the DPO thread is that there was a bit of support, but most of the discussion was a digression around a general solution.
Likewise. In general I am a fan of these type of CLIs, but this |
I concur with @hugovk and I suggest to close this issue as not planned. |
Feature or enhancement
Proposal:
Introduction
I often find it necessary to use some
shutil
functionalities in scripts. It does the right thing efficiently, has more precise error handling thancmake -E
, and, most importantly, is cross-platform.Precedent
The
zipfile
module can be used bypy -m zipfile
. It gains credits for being a cross-platform ZIP64 decompressor.Details
copyfile
,copystat
,copy
,copy2
,copytree
,rmtree
,move
,chown
,which
,make_archive
, andunpack_archive
;--kw arg
cmdline options; flags can follow the style--follow_symlinks
and--no-follow_symlinks
.shutil
)Links
DPO: https://discuss.python.org/t/turn-shutil-into-a-runnable-module/70503
Linked PRs
The text was updated successfully, but these errors were encountered: