Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn on deprecated images being set #2312

Merged
merged 4 commits into from
Mar 11, 2025
Merged

fix: warn on deprecated images being set #2312

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fa0075
fix: warn on deprecated images being set
henryiii Mar 10, 2025
d39843a
fix: handle repeated warning messages
henryiii Mar 10, 2025
2a25c6d
Apply suggestions from code review
henryiii Mar 10, 2025
8a190f4
fix: try making the warnings once per Options
henryiii Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cibuildwheel/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,14 @@ def _compute_build_options(self, identifier: str | None) -> BuildOptions:
# default to manylinux2014
image = pinned_images["manylinux2014"]
elif config_value in pinned_images:
if config_value in {
"manylinux1",
"manylinux2010",
"manylinux_2_24",
"musllinux_1_1",
}:
msg = f"Unmaintained image, either upgrade to a supported image or pin directly to {pinned_images[config_value]!r}"
log.warning(msg)
image = pinned_images[config_value]
else:
image = config_value
Expand Down
Loading