Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn on deprecated images being set #2312

Merged
merged 4 commits into from
Mar 11, 2025
Merged

fix: warn on deprecated images being set #2312

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fa0075
fix: warn on deprecated images being set
henryiii Mar 10, 2025
d39843a
fix: handle repeated warning messages
henryiii Mar 10, 2025
2a25c6d
Apply suggestions from code review
henryiii Mar 10, 2025
8a190f4
fix: try making the warnings once per Options
henryiii Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions cibuildwheel/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@ def __init__(
self.command_line_arguments = command_line_arguments
self.env = env
self._defaults = defaults
self._image_warnings = set[str]()

self.reader = OptionsReader(
None if defaults else self.config_file_path,
Expand Down Expand Up @@ -775,6 +776,24 @@ def _compute_build_options(self, identifier: str | None) -> BuildOptions:
# default to manylinux2014
image = pinned_images["manylinux2014"]
elif config_value in pinned_images:
if (
config_value
in {
"manylinux1",
"manylinux2010",
"manylinux_2_24",
"musllinux_1_1",
}
and config_value not in self._image_warnings
):
self._image_warnings.add(config_value)
msg = (
f"Deprecated image {config_value!r}. This value will not work"
" in a future version of cibuildwheel. Either upgrade to a supported"
" image or continue using the deprecated image by pinning directly"
f" to {pinned_images[config_value]!r}."
)
log.warning(msg)
image = pinned_images[config_value]
else:
image = config_value
Expand Down
Loading