Skip to content

Remove redundant pre-commit job #7285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Apr 28, 2024

As we have the pre-commit-ci (https://pre-commit.ci/), we do not to have a pre-commit GitHub action right?


📚 Documentation preview 📚: https://pymc--7285.org.readthedocs.build/en/7285/

@juanitorduz juanitorduz requested a review from ricardoV94 April 28, 2024 09:27
@juanitorduz juanitorduz added Github CI/CD no releasenotes Skipped in automatic release notes generation labels Apr 28, 2024
@ricardoV94 ricardoV94 requested a review from maresb April 28, 2024 13:20
Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I meant to do this as per #7102 (comment). As I remark there, before merging we should rename this workflow to mypy.yml.

@juanitorduz
Copy link
Contributor Author

Ok! I will rename it :)

@juanitorduz juanitorduz requested a review from maresb April 28, 2024 18:24
@ricardoV94 ricardoV94 merged commit bce7116 into pymc-devs:main Apr 28, 2024
10 checks passed
@ricardoV94
Copy link
Member

Thanks @juanitorduz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github CI/CD no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants