Skip to content

Eliminate duplicate pre-commit GitHub Actions workflow #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maresb opened this issue Jan 23, 2024 · 2 comments
Closed

Eliminate duplicate pre-commit GitHub Actions workflow #7113

maresb opened this issue Jan 23, 2024 · 2 comments

Comments

@maresb
Copy link
Contributor

maresb commented Jan 23, 2024

Description

The current pre-commit workflow should be renamed to mypy and the pre-commit part removed. We should try to run the hooks on the oldest supported Python to get a fast fail when someone uses a too-modern Python feature.

Note that #7112 deletes the pre-commit autoupdate workflow while here I'm proposing to modify the main pre-commit workflow.

@markgreene74
Copy link
Contributor

Hi @maresb @ricardoV94 I am at the Code Sprint (PyData London) looking for issues to work on.

I was wondering if this issue should be closed? Looks like the pre-commit workflow was removed.

See this comment and the actual commit here.

@maresb
Copy link
Contributor Author

maresb commented Jun 7, 2025

Ah, right, thanks so much @markgreene74 for catching this, I really appreciate it!

Your link to the commit seems to be broken. The correct link is #7285

@maresb maresb closed this as completed Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants